API: Move generic catalog methods to API#3244
Merged
rdblue merged 2 commits intoapache:masterfrom Oct 8, 2021
Merged
Conversation
nastra
reviewed
Oct 8, 2021
| public abstract class BaseMetastoreCatalog implements Catalog { | ||
| private static final Logger LOG = LoggerFactory.getLogger(BaseMetastoreCatalog.class); | ||
|
|
||
| @Override |
Contributor
There was a problem hiding this comment.
nit: I think the same methods can be removed from CachingCatalog as well
yyanyy
approved these changes
Oct 8, 2021
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves implementations that translate from
Catalogmethods to theTableBuilderAPI into theCataloginterface rather than inBaseMetastoreCatalog. This should avoid implementing them in other non-metastore catalogs.