[Benchmark] Improve perf of Dictionary Benchmark Setup#3329
Merged
rdblue merged 1 commit intoapache:masterfrom Oct 20, 2021
Merged
[Benchmark] Improve perf of Dictionary Benchmark Setup#3329rdblue merged 1 commit intoapache:masterfrom
rdblue merged 1 commit intoapache:masterfrom
Conversation
Previously the benchmarking code used a number of "when" constructs to generate data in rings. This became much more expensive somewhere between Spark 2.4.5 and 2.4.6 for reasons we are not certain of. In an attempt to improve performance we have removed all of these constructs and replaced them with identical modulo operations and add date operations when applicable.
rdblue
approved these changes
Oct 20, 2021
Contributor
|
Good catch! |
Contributor
|
I'm going to merge this before tests pass because it only modifies benchmark code that won't affect tests. |
nastra
approved these changes
Oct 20, 2021
kbendick
reviewed
Oct 20, 2021
Contributor
kbendick
left a comment
kbendick
left a comment
There was a problem hiding this comment.
Thanks for doing this. Checked it out and seems to be the same.
Member
Author
|
Ahh it wasn't done :( I broke the spark2 jmh tests, just fixed and pushed |
Member
Author
Contributor
|
fixes #3157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the benchmarking code used a number of "when" constructs to
generate data in rings. This became much more expensive somewhere between
Spark 2.4.5 and 2.4.6 for reasons we are not certain of. In an attempt
to improve performance we have removed all of these constructs and
replaced them with identical modulo operations and add date operations
when applicable.