Remove deprecated APIs up to 0.12.#3331
Conversation
| this.nullValueCounts = nullValueCounts; | ||
| } | ||
|
|
||
| public Metrics(Long rowCount, |
There was a problem hiding this comment.
Looks like this one wasn't deprecated.
There was a problem hiding this comment.
Let's add more deprecations in a separate commit though.
| .addFile(FILE_DAY_2_MODIFIED) | ||
| .validateNoConflictingAppends(baseSnapshot.snapshotId(), EXPRESSION_DAY_2) | ||
| .validateFromSnapshot(baseSnapshot.snapshotId()) | ||
| .validateNoConflictingAppends(EXPRESSION_DAY_2) |
There was a problem hiding this comment.
I think validateNoConflictingAppends has been deprecated as well.
We should use conflictDetectionFilter and validateNoConflictingData.
|
This looks mostly good to me. The only question is the removed constructor in Also, we missed a few methods in |
|
We should also cover |
|
Thanks @aokolnychyi for the review. I will remove the deprecated methods in 0.13 in a follow-up PR. |
|
@flyrain While we are at it you may want to remove TestNewRewriteAction for Spark 2 since it is currently dead code |
|
@RussellSpitzer, we may remove TestNewRewriteAction in another PR since this one is for removing deprecated APIs. |
| * @deprecated this will be removed in 0.11.0; use {@link #visit(PartitionSpec, PartitionSpecVisitor)} instead. | ||
| */ | ||
| @Deprecated | ||
| static <R> List<R> visit(Schema schema, PartitionSpec spec, PartitionSpecVisitor<R> visitor) { |
There was a problem hiding this comment.
Looks good. It is a little odd that we deprecated this method but still used it in the recommended alternative.
|
Thanks, @flyrain! |
4 participants
Remove all deprecated APIs which are supposed to removed up to release 0.12.
cc @aokolnychyi, @rdblue, @jackye1995, @RussellSpitzer, @karuppayya, @szehon-ho