Hotfix - Remove additional parens to satisfy checkstyle for 1.12.1 cherry-picking #3386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….1 cherry-picking
Contributor
|
Sorry there is an extra parenthesis here. Thanks, @kbendick |
Contributor
Author
No worries @izchen! I don't think on the present CI it causes any issue. It's just when I cherry-pick it to a branch that has the checkstyle set up before the recent CI refactor that it causes me this issue. So it's not really something you should have noticed as the test suite didn't complain. 👍 |
rdblue
approved these changes
Oct 31, 2021
Contributor
|
@kbendick, did you intend for this to go into the 0.12.x branch? It's against master. |
Contributor
|
I see the comment over on #3385 so I'm merging this. |
Contributor
Author
Thank you! |
kbendick
added a commit
to kbendick/iceberg
that referenced
this pull request
Nov 1, 2021
kbendick
added a commit
to kbendick/iceberg
that referenced
this pull request
Nov 1, 2021
rdblue
pushed a commit
that referenced
this pull request
Nov 1, 2021
izchen
pushed a commit
to izchen/iceberg
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the cherry-picking for creating the initial release candidate for 1.12.1, while trying to cherry-pick this PR, #3368, a checkstyle error fails the build.
For some reason, this doesn't come up during the current build / CI, but I need to apply this hotfix to be able to cherry-pick the above PR as cleanly as possible into the 1.12.x branch (and I have a feeling that this might be hinting at some underlying CI tests that aren't being run entirely, for example the Spark v3.2 tests possibly).
cc @rdblue