Skip to content

add rowsDivisor to modify for RollingFileWriter#3488

Closed
zhaomin1423 wants to merge 1 commit intoapache:masterfrom
zhaomin1423:rollingFileWriter
Closed

add rowsDivisor to modify for RollingFileWriter#3488
zhaomin1423 wants to merge 1 commit intoapache:masterfrom
zhaomin1423:rollingFileWriter

Conversation

@zhaomin1423
Copy link
Member

add a config to set rows for rolling file write.

@rdblue
Copy link
Contributor

rdblue commented Nov 7, 2021

What is the use case for this setting? Do you have data to show that in some situations, 1000 is too small or too large? A much simpler fix is to update this setting for all tables. I'd like to make sure it is necessary to add a config for this instead of just fixing it.

@aokolnychyi
Copy link
Contributor

It is a large change. I'd also want to get a bit more information to prove it is actually needed.

@rdblue
Copy link
Contributor

rdblue commented Nov 11, 2021

I'm closing this until there is a known use case for it. While I appreciate you taking the time to build it, we don't want to add options that are not needed for real-world use. We can reopen this if a use case for it turns up.

@rdblue rdblue closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments