add rowsDivisor to modify for RollingFileWriter#3488
Closed
zhaomin1423 wants to merge 1 commit intoapache:masterfrom
Closed
add rowsDivisor to modify for RollingFileWriter#3488zhaomin1423 wants to merge 1 commit intoapache:masterfrom
zhaomin1423 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
What is the use case for this setting? Do you have data to show that in some situations, 1000 is too small or too large? A much simpler fix is to update this setting for all tables. I'd like to make sure it is necessary to add a config for this instead of just fixing it. |
Contributor
|
It is a large change. I'd also want to get a bit more information to prove it is actually needed. |
Contributor
|
I'm closing this until there is a known use case for it. While I appreciate you taking the time to build it, we don't want to add options that are not needed for real-world use. We can reopen this if a use case for it turns up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a config to set rows for rolling file write.