Move openCurrentWriter to base class#3492
Closed
zhaomin1423 wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
rdblue
reviewed
Nov 7, 2021
| super(fileFactory, io, targetFileSizeInBytes, spec, partition); | ||
| this.writerFactory = writerFactory; | ||
| this.dataFiles = Lists.newArrayList(); | ||
| openCurrentWriter(); |
Contributor
There was a problem hiding this comment.
openCurrentWriter calls newWriter, which is implemented by subclasses. In this case, it uses writerFactory. Calling openCurrentWriter in the parent class will cause newWriter to be called before setting writerFactory.
Member
Author
There was a problem hiding this comment.
Sorry, I ignored it. Thanks for pointing out my mistake.
Contributor
|
I ran CI to demonstrate the issue with this change. Here's the test failure: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openCurrentWriter is related to the method of write, so I think that it is more appropriate to move it here.