Skip to content

Spark 3.0: Make SparkCatalog#alterTable conform to TableCatalog interface#3674

Merged
rdblue merged 1 commit intoapache:masterfrom
wypoon:3548_spark30
Dec 6, 2021
Merged

Spark 3.0: Make SparkCatalog#alterTable conform to TableCatalog interface#3674
rdblue merged 1 commit intoapache:masterfrom
wypoon:3548_spark30

Conversation

@wypoon
Copy link
Contributor

@wypoon wypoon commented Dec 5, 2021

Port of #3548 to 3.0.
Fix is due to Xinbin Huang (@xinbinhuang).

@github-actions github-actions bot added the spark label Dec 5, 2021
@wypoon
Copy link
Contributor Author

wypoon commented Dec 5, 2021

The fix is applicable to Spark 3.0 as well (TableCatalog#alterTable is supposed to return the updated metadata).
@RussellSpitzer can you please review? You merged #3548.

@wypoon
Copy link
Contributor Author

wypoon commented Dec 5, 2021

cc @kbendick

Copy link
Contributor

@kbendick kbendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Since it's a small change and a port, can you do 3.1 and 3.0 in this same PR? As well as 2.4 (assuming it applies there, which I'm sure it does).

@kbendick
Copy link
Contributor

kbendick commented Dec 5, 2021

Oh and you might consider marking @xinbinhuang as co-author considering they wrote the original PR.

It's just part of the PR comment (if you didn't already know): https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line

@wypoon
Copy link
Contributor Author

wypoon commented Dec 5, 2021

This looks good to me. Since it's a small change and a port, can you do 3.1 and 3.0 in this same PR? As well as 2.4 (assuming it applies there, which I'm sure it does).

I have already created PRs for both 3.1 and 3.0, since I understood that to be the convention.
There is no SparkCatalog in 2.4.

@wypoon
Copy link
Contributor Author

wypoon commented Dec 5, 2021

Added @xinbinhuang as co-author. Thanks for the tip, @kbendick.

…face

Port of apache#3548 to 3.0.
Fix is due to Xinbin Huang (@xinbinhuang).

Co-authored-by: Xinbin Huang <bin.huangxb@gmail.com>
@kbendick
Copy link
Contributor

kbendick commented Dec 6, 2021

This looks good to me. Since it's a small change and a port, can you do 3.1 and 3.0 in this same PR? As well as 2.4 (assuming it applies there, which I'm sure it does).

I have already created PRs for both 3.1 and 3.0, since I understood that to be the convention. There is no SparkCatalog in 2.4.

Ahh I hadn't noticed at the time that there was ready another PR. I found my way to this review via E-mail.

Then no worries. That would just be more work. This looks good.

Copy link
Contributor

@kbendick kbendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wypoon! LGTM.

Sorry I didnt notice there was a PR for the other version already. Thanks for handling these backports.

@rdblue rdblue merged commit 8ee7cb1 into apache:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants