Spark 3.0: Make SparkCatalog#alterTable conform to TableCatalog interface#3674
Spark 3.0: Make SparkCatalog#alterTable conform to TableCatalog interface#3674rdblue merged 1 commit intoapache:masterfrom
Conversation
|
The fix is applicable to Spark 3.0 as well ( |
|
cc @kbendick |
kbendick
left a comment
There was a problem hiding this comment.
This looks good to me. Since it's a small change and a port, can you do 3.1 and 3.0 in this same PR? As well as 2.4 (assuming it applies there, which I'm sure it does).
|
Oh and you might consider marking @xinbinhuang as co-author considering they wrote the original PR. It's just part of the PR comment (if you didn't already know): https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line |
I have already created PRs for both 3.1 and 3.0, since I understood that to be the convention. |
|
Added @xinbinhuang as co-author. Thanks for the tip, @kbendick. |
…face Port of apache#3548 to 3.0. Fix is due to Xinbin Huang (@xinbinhuang). Co-authored-by: Xinbin Huang <bin.huangxb@gmail.com>
Ahh I hadn't noticed at the time that there was ready another PR. I found my way to this review via E-mail. Then no worries. That would just be more work. This looks good. |
Port of #3548 to 3.0.
Fix is due to Xinbin Huang (@xinbinhuang).