Doc : Modify the attribute description#3694
Merged
rdblue merged 4 commits intoapache:masterfrom Dec 12, 2021
Merged
Conversation
kbendick
approved these changes
Dec 10, 2021
Contributor
kbendick
left a comment
kbendick
left a comment
There was a problem hiding this comment.
These are good finds @q977734161!
Some small feedback. But overall, this is a good discovery!
site/docs/configuration.md
Outdated
| | commit.retry.min-wait-ms | 100 | Minimum time in milliseconds to wait before retrying a commit | | ||
| | commit.retry.max-wait-ms | 60000 (1 min) | Maximum time in milliseconds to wait before retrying a commit | | ||
| | commit.retry.total-timeout-ms | 1800000 (30 min) | Maximum time in milliseconds to wait before retrying a commit | | ||
| | commit.retry.total-timeout-ms | 1800000 (30 min) | Totals retry timeout period in milliseconds for a commit | |
Contributor
There was a problem hiding this comment.
Nit: Total has an extra s on the end.
site/docs/configuration.md
Outdated
| | commit.status-check.min-wait-ms | 1000 (1s) | Minimum time in milliseconds to wait before retrying a status-check | | ||
| | commit.status-check.max-wait-ms | 60000 (1 min) | Maximum time in milliseconds to wait before retrying a status-check | | ||
| | commit.status-check.total-timeout-ms| 1800000 (30 min) | Maximum time in milliseconds to wait before retrying a status-check | | ||
| | commit.status-check.total-timeout-ms| 1800000 (30 min) | Totals status-check timeout period in milliseconds | |
Contributor
There was a problem hiding this comment.
Nit / non-blocking: Consider Total timeout period in which the commit status-check must succeed, in milliseconds
Also, Total has an extra s presently here as well.
rdblue
approved these changes
Dec 12, 2021
Contributor
|
Thanks, @q977734161! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Table behavior properties attribute descriptions are a bit problematic