Core: ensure Kryo serializability of MetricsConfig#3702
Merged
jackye1995 merged 2 commits intoapache:masterfrom Dec 10, 2021
jackye1995:metrics-config-kryo
Merged
Core: ensure Kryo serializability of MetricsConfig#3702jackye1995 merged 2 commits intoapache:masterfrom jackye1995:metrics-config-kryo
jackye1995 merged 2 commits intoapache:masterfrom
jackye1995:metrics-config-kryo
Conversation
jackye1995
commented
Dec 9, 2021
|
|
||
| private static final MetricsConfig DEFAULT = new MetricsConfig(ImmutableMap.of(), | ||
| MetricsModes.fromString(DEFAULT_WRITE_METRICS_MODE_DEFAULT)); | ||
| MetricsModes.fromString(DEFAULT_WRITE_METRICS_MODE_DEFAULT)); |
Contributor
Author
There was a problem hiding this comment.
Indentation was off, also fixed along the way
kbendick
approved these changes
Dec 9, 2021
Contributor
kbendick
left a comment
kbendick
left a comment
There was a problem hiding this comment.
LGTM.
Should we add a test to roundtrip MetricsConfig with the kryo serializer and the java serializer?
rdblue
approved these changes
Dec 10, 2021
Contributor
|
Thanks, @jackye1995! |
kbendick
approved these changes
Dec 10, 2021
Contributor
Author
|
Thanks for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3638 , we improved
MetricsConfigconstruction and marked it as immutable. As @aokolnychyi pointed out the class was used for serialization before we introducedSerializableTable. Although it is not likely that people are still serializing the metrics config, because it implements theSerializableinterface, it's still safer to useSerializableMapinstead ofImmutableMapfor this to avoid any potential trouble.