[python legacy] Support passing customized protocol for hms client#4041
Merged
rdblue merged 1 commit intoapache:masterfrom Feb 6, 2022
Merged
Conversation
Contributor
Author
jun-he
reviewed
Feb 6, 2022
|
|
||
| def get_client(self) -> HMSClient: | ||
| from urllib.parse import urlparse | ||
| iprot = self.conf.get(HiveTables.IPROT) |
Collaborator
There was a problem hiding this comment.
Do we need to put a default value? Will it still work if iprot and oprot are None value?
Contributor
Author
There was a problem hiding this comment.
@jun-he I don't think we need a default value. As when iprot is None, it will just use host and port value. https://github.com/gglanzani/hmsclient/blob/master/hmsclient/hmsclient.py#L42
Contributor
|
Thanks, @puchengy! |
puchengy
added a commit
to pinterest/iceberg
that referenced
this pull request
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to enable kerberized HMS support.