Bump Nessie from 0.18.0 to 0.19.0#4055
Conversation
snazy
force-pushed
the
bump-nessie-0.19.0
branch
from
7926400 to
99e80c2
Compare
|
nit: maybe rename commit + PR title to |
| public void beforeEach() throws IOException { | ||
| uri = server.getURI().toString(); | ||
| this.api = HttpClientBuilder.builder().withUri(uri).build(NessieApiV1.class); | ||
| public void beforeEach(@NessieUri URI nessieUri) throws IOException { |
There was a problem hiding this comment.
Question: What does this do / how does this work? Anything you can point me to (PR, etc) so I can peruse it myself?
There was a problem hiding this comment.
That was part of some refactoring for the test-related code, actually: make Jersey correctly expose the "right" base URI, as there was a bug when multiple tests using that Jersey-based code ran concurrently.
Previously there was a getter-method on the "server" class, but that became a parameter being filled from the JUnit5 extension (hence the @NessieUri annotation).
There was a problem hiding this comment.
just for completeness for @kbendick, this was introduced in projectnessie/nessie#3073
kbendick
left a comment
kbendick
left a comment
There was a problem hiding this comment.
LGTM.
I think there's a nessie version in the site docs (or there was). So you might want to make a note to follow up on that. They just underwent a big refactor (and are still undergoing finishing touches on that) so you might have to wait depending but FYI. 🙂
snazy
force-pushed
the
bump-nessie-0.19.0
branch
from
99e80c2 to
17664b0
Compare
snazy
force-pushed
the
bump-nessie-0.19.0
branch
from
17664b0 to
5576521
Compare
In the Iceberg repo, Nessie is updated to 0.19.0 in apache/iceberg#4055 Hence updating the site docs config.
|
Handled the site doc update. |
5 participants
No description provided.