[Spark] Delete dataFile on iteration level in SparkParquetWritersFlatDataBenchmark#4149
Merged
rdblue merged 1 commit intoapache:masterfrom Feb 21, 2022
Merged
[Spark] Delete dataFile on iteration level in SparkParquetWritersFlatDataBenchmark#4149rdblue merged 1 commit intoapache:masterfrom
rdblue merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
@nastra or @RussellSpitzer, can you review this one? Thank you! |
Contributor
|
@rdblue or @RussellSpitzer when you merge this one, please also merge #3910 as it fixes the same issue for Spark 3.2 benchmarks |
Contributor
|
Thanks, @yaooqinn! |
arminnajafi
pushed a commit
to arminnajafi/iceberg
that referenced
this pull request
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor issue for a jmh test -
SparkParquetWritersFlatDataBenchmarkThe
dataFileholds mocked outputs now cleaned atLevel.Trialwhich will be executed after the set of benchmark iterations. Then, it cause errors like below.In this PR, I set the TearDown level to Iteration to make the dataFile be deleted after each iteration.