Test: Add test for remove orphan files with delete files #4182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
changed the title
RussellSpitzer
approved these changes
Feb 22, 2022
Member
Author
|
Thanks for the fast review! |
Contributor
|
LGTM too. @szehon-ho, could you check whether we have similar tests for expiring snapshots via the |
Member
Author
|
sure, will take a look |
arminnajafi
pushed a commit
to arminnajafi/iceberg
that referenced
this pull request
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple test for validating remove orphans work with Delete Files, in particular that they do not remove the delete files.