Core: Use existing SnapshotRefParser when serializing ref information in TableMetadata Parser#4294
Merged
rdblue merged 1 commit intoapache:masterfrom Mar 16, 2022
Conversation
amogh-jahagirdar
force-pushed
the
table-metadata-ref-serde
branch
from
01d93ef to
4e90d98
Compare
rdblue
reviewed
Mar 11, 2022
amogh-jahagirdar
force-pushed
the
table-metadata-ref-serde
branch
2 times, most recently
from
411c03d to
923b983
Compare
… in TableMetadataParser
amogh-jahagirdar
force-pushed
the
table-metadata-ref-serde
branch
from
923b983 to
ef52725
Compare
rdblue
approved these changes
Mar 16, 2022
Contributor
|
Thanks, @amogh-jahagirdar! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a follow on to @rdblue change in #4260 . Since we have an existing SnapshotRefParser I think we can leverage that and reduce some of the implementation in TableMetadataParser.
Let me know your thoughts! @rdblue @jackye1995