AWS: Fix TestGlueCatalogTable failure#4355
Merged
jackye1995 merged 1 commit intoapache:masterfrom Mar 17, 2022
Merged
Conversation
singhpk234
reviewed
Mar 17, 2022
| static final Map<String, String> tableLocationProperties = ImmutableMap.of( | ||
| TableProperties.WRITE_DATA_LOCATION, "s3://" + testBucketName + "/writeDataLoc", | ||
| TableProperties.WRITE_METADATA_LOCATION, "s3://" + testBucketName + "/writeMetaDataLoc", | ||
| TableProperties.WRITE_DATA_LOCATION, "s3://" + testBucketName + "/writeDataLoc", |
Contributor
There was a problem hiding this comment.
I would recommend changing this :
sort both the collections as it may happen post picking these changes it failing in my machine
Assert.assertEquals("additionalLocations should match", tableLocationProperties.values().stream().sorted().collect(
Collectors.toList()),
response.table().storageDescriptor().additionalLocations().stream().sorted().collect(Collectors.toList()));as I can confirm that for the present master branch these tests passes on my machine
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. That makes sense as we are comparing a map's valueSet and a list. I have updated the change. Please have another look.
singhpk234
approved these changes
Mar 17, 2022
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, Thanks @xiaoxuandev for the fix :) !!
jackye1995
approved these changes
Mar 17, 2022
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
also looks good to me!
jackye1995
reviewed
Mar 17, 2022
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.