AWS: Add TagSession support in AssumeRoleAwsClientFactory#4358
Merged
jackye1995 merged 1 commit intoapache:masterfrom Mar 18, 2022
Merged
AWS: Add TagSession support in AssumeRoleAwsClientFactory#4358jackye1995 merged 1 commit intoapache:masterfrom
jackye1995 merged 1 commit intoapache:masterfrom
Conversation
jackye1995
reviewed
Mar 17, 2022
aws/src/integration/java/org/apache/iceberg/aws/TestAssumeRoleAwsClientFactory.java
Show resolved
Hide resolved
xiaoxuandev
force-pushed
the
add-assume-role-tags
branch
from
0bbc125 to
01e36b2
Compare
jackye1995
approved these changes
Mar 18, 2022
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
looks good to me, waiting for CI pass
Contributor
| return String.format("iceberg-aws-%s", UUID.randomUUID()); | ||
| } | ||
|
|
||
| private static Set<Tag> toTags(Map<String, String> properties) { |
Contributor
There was a problem hiding this comment.
We have a similar method in AwsProperties. Can we re-use that?
iceberg/aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
Lines 459 to 464 in d2bb30f
Contributor
There was a problem hiding this comment.
I think we cannot reuse, this is STS tag, not S3 tag, different class.
singhpk234
approved these changes
Mar 18, 2022
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, Thanks @xiaoxuandev for this !!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.