Skip to content

Comments

Spec: Clean up error responses in REST protocol#4367

Merged
rdblue merged 2 commits intoapache:masterfrom
rdblue:rest-update-response-codes
Mar 27, 2022
Merged

Spec: Clean up error responses in REST protocol#4367
rdblue merged 2 commits intoapache:masterfrom
rdblue:rest-update-response-codes

Conversation

@rdblue
Copy link
Contributor

@rdblue rdblue commented Mar 20, 2022

This cleans up some of the error response documentation in the REST protocol.

  • Documents 500 and 504 specifically in the table commit route
  • Adds stack to error responses for sending server-side stack traces (optional)
  • Adds 419 to all routes to signal that authentication has timed out
  • Adds 503 to all routes for a back-pressure signal

@rdblue rdblue requested review from danielcweeks and kbendick March 20, 2022 21:54
Copy link
Contributor

@danielcweeks danielcweeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kbendick kbendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, but overall this looks good to me.

Thank you @rdblue!

@rdblue rdblue merged commit 5235a70 into apache:master Mar 27, 2022
@rdblue
Copy link
Contributor Author

rdblue commented Mar 27, 2022

Thanks for reviewing, @kbendick and @danielcweeks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants