[Spec] Clarify whether floating point lower and upper bounds can contain NaNs#4404
Merged
rdblue merged 3 commits intoapache:masterfrom Mar 27, 2022
Merged
[Spec] Clarify whether floating point lower and upper bounds can contain NaNs#4404rdblue merged 3 commits intoapache:masterfrom
rdblue merged 3 commits intoapache:masterfrom
Conversation
Contributor
|
You're correct. NaN values are not allowed in lower or upper bounds. Thanks! |
rdblue
approved these changes
Mar 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is somewhat pedantic. Based on current wording:
Each value must be less than or equal to all non-null, non-NaN values in the column for the file [2]Based on defined sorting statistics
Sorting floating-point numbers should produce the following behavior: -NaN < -Infinity < -value < -0 < 0 < value < Infinity < NaN-NaN could be a lower bound and NaN could be an upper bound.This PR tries to clarify whether statistics can or can't used for lower and upper bounds (I think the first sentence quoted might have been intended to rule out NaN but it isn't clear, so I'm happy to reverse this language to state that +/- NaN are valid values for bounds if that is the case).