Spark: Update Spark 3.2 JMH Benchmark javadoc instructions#4409
Merged
rdblue merged 1 commit intoapache:masterfrom Mar 27, 2022
Merged
Conversation
rdblue
approved these changes
Mar 27, 2022
Contributor
|
Thanks, @kbendick! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a followup to #4328, the Spark JMH benchmarks previously had invalid commands in their JavaDoc comments since we migrated to version specific Spark builds.
This updates all of the Spark 3.2 tests to include the
sparkVersionssystem property, so that the tests are correct even when we move to Spark 3.3 or change the default spark version.This also updates 4 tests that were missed in #4328