Skip to content

Static Analysis: Lambda should be a method reference#4442

Merged
rdblue merged 54 commits intoapache:masterfrom
felixYyu:Lambda-method-reference
Apr 3, 2022
Merged

Static Analysis: Lambda should be a method reference#4442
rdblue merged 54 commits intoapache:masterfrom
felixYyu:Lambda-method-reference

Conversation

@felixYyu
Copy link
Copy Markdown
Contributor

@felixYyu felixYyu commented Mar 31, 2022

@rdblue
Copy link
Copy Markdown
Contributor

rdblue commented Mar 31, 2022

This looks fine to me. What is the motivation? Does this fix a static analysis warning? If so, could you please update the description?

@felixYyu
Copy link
Copy Markdown
Contributor Author

felixYyu commented Apr 1, 2022

this fix a static analysis warning, the static check error log:

iceberg\flink\v1.14\flink\src\main\java\org\apache\iceberg\flink\source\FlinkSplitPlanner.java:73: [LambdaMethodReference] Lambda should be a method reference
          task -> IcebergSourceSplit.fromCombinedScanTask(task)));
          ^
    (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks)
  Did you mean 'IcebergSourceSplit::fromCombinedScanTask));'?

@felixYyu felixYyu changed the title Lambda should be a method reference Static Analysis: Lambda should be a method reference Apr 2, 2022
@felixYyu felixYyu requested a review from rdblue April 2, 2022 07:19
@rdblue rdblue merged commit 7ac5061 into apache:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants