Spark: Ignore SQL comments when testing if command is Iceberg DDL - Backport to Spark 3.0#4497
Merged
szehon-ho merged 1 commit intoapache:masterfrom Apr 20, 2022
Conversation
Contributor
Author
|
This fixes this issue #4289 in Spark 3.0. |
kbendick
force-pushed
the
backport-spark-stored-procedure-comments-spark30
branch
from
5840200 to
c3cc1a1
Compare
…c DDL - Backport to Spark 3.0
kbendick
force-pushed
the
backport-spark-stored-procedure-comments-spark30
branch
from
c49ea06 to
cb681da
Compare
singhpk234
approved these changes
Apr 12, 2022
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
Thanks @kbendick for the change :), LGTM !!
szehon-ho
approved these changes
Apr 20, 2022
Member
|
Thanks @kbendick for change, @singhpk234 for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #4396 to Spark 3.0
Allow for procedures to have leading comments when checking if the command is Iceberg specific DDL.
This allows for systems that add leading comments to SQL statements for metadata purposes, such as dbt, to work if the command in question is an Iceberg Spark Procedure.