Removed un-used function converterFor from class ParquetMetricsRowGroupFilter#4548
Merged
jackye1995 merged 1 commit intoapache:masterfrom Apr 18, 2022
Conversation
…icsRowGroupFilter
Andre9580
changed the title
rajarshisarkar
approved these changes
Apr 15, 2022
Contributor
rajarshisarkar
left a comment
rajarshisarkar
left a comment
There was a problem hiding this comment.
Looks good to me as CI is passing and the unused function is private.
jackye1995
approved these changes
Apr 18, 2022
Contributor
|
thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running
./gradlew build -x test -x integrationTestto build the iceberg project, I noticed that the private functionconverterForfrom classParquetMetricsRowGroupFilterwas not used in the repo. This is why I wanted to remove it. Please feel free to let me know if that makes sense.