Core - Fix field name bug in LoadTableResponse object to match REST spec and properly deserialize#4642
Merged
danielcweeks merged 1 commit intoapache:masterfrom Apr 27, 2022
Conversation
danielcweeks
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LoadTableResponseclass has aTableMetadatafield calledmetadata.It's currently called
meta. Using Jackson to infer the fields will result in incorrect results because the name is not correct / does not match the spec.I am updating this as a hot fix, and am working on a comprehensive test suite for this class that I'll open after a few other earlier PRs come in. But this will make the REST objects match the spec now, so that anybody implementing it can work with the correct objects.
cc @rdblue @danielcweeks