Closed
Conversation
Contributor
|
@funcheetah, these change cannot go in the spec. Iceberg does not allow union data. It is fine for Iceberg implementations to support reading unions as structs for backward compatibility, but that is optional behavior and should not be required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apache Iceberg does not support non-optional union types (e.g. [“int”, “string”]). This PR add spec to support non-optional union types.
Representation
non-optional union type can be converted to original type for single type union or struct for complex union.
The struct representations converted from non-optional union types are consistent with non-optional union support added in Trino in trinodb/trino#3483.
Deep nested non-optional union types are supported.
Examples
Basic
[“int”, “string”] -> struct<tag int, field0 int, field1 string>
Single type
[“int”] -> int
Implementation PRs
TODO