Core: remove reference files for BaseEqualityDeltaWriter#4733
Closed
chenjunjiedada wants to merge 1 commit intoapache:masterfrom
Closed
Core: remove reference files for BaseEqualityDeltaWriter#4733chenjunjiedada wants to merge 1 commit intoapache:masterfrom
chenjunjiedada wants to merge 1 commit intoapache:masterfrom
Conversation
chenjunjiedada
force-pushed
the
remove-ref-data-files
branch
from
139966e to
2d8b120
Compare
Contributor
|
I don't think this is a good idea. While Flink may not need the referenced files set, the writer that you're modifying here lives in core and could be used by other modules. If this were entirely in Flink I think it would be fine, but it probably isn't a good idea to modify this class. |
Collaborator
Author
|
Sounds reasonable to me. Let me close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flink upsert commit doesn't validate the conflict of data files that position deletes referred, thus it doesn't have to keep referred data files of position deletes in memory anymore.