Docs: Add StarRocks to Documentation#4774
Conversation
|
Thanks for opening this PR and for linking the PR in the docs repo @caneGuy! I have only recently discovered StarRocks but it is very exciting. I look forward to the chance to learn more about it and hopefully use it. In full transparency, I can't recall if the PR is supposed to be made here or in iceberg-docs, but can point out the person who will be more sure 👍 |
|
cc @samredai for visibility on including a link to external documentation for an additional query engine. There's also a PR open in iceberg-docs already linked here 👍 |
|
Thanks too much @kbendick |
|
@samredai could you help review this pr thanks! |
samredai
left a comment
There was a problem hiding this comment.
LGTM! We should merge the image in the iceberg-docs repo before this is released (there should be a docs release soon as part of the 0.13.2 release)
kbendick
left a comment
There was a problem hiding this comment.
+1 this looks good to me.
My one outstanding question, which isn't a blocker as some similar files don't even seem to have it, is whether or not the ASF license header can be at the top of the file.
But if it passes the rat license check and it does indeed have the license, I think that's sufficient given some similar files don't have it at all.
|
could you help merge this ? @kbendick thanks |
|
@rdblue could you help reload the web site? and how can we see this logo and link on iceberg website. thanks too much |
|
@samredai, can you help port this to the iceberg-docs repo? |
This PR adds a link to the documentation for StarRocks querying for Iceberg tables.