Closed
Conversation
danielcweeks
approved these changes
Jun 9, 2022
Contributor
|
@Fokko, can you rebase? |
rdblue
approved these changes
Jun 12, 2022
Fokko
force-pushed
the
fd-consolidate-types
branch
from
2ed1cbd to
12cfa42
Compare
Contributor
Author
|
@rdblue @danielcweeks rebased :) |
Fokko
force-pushed
the
fd-consolidate-types
branch
from
12cfa42 to
fdd548f
Compare
Contributor
|
@Fokko, is this no longer needed? Looks like I was probably just waiting for tests to pass and never made it back to merge it. Just let me know what you'd like to do here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move away from Types to the build in types.
When we add
We can also use the buildin types in Python 3.8