Encapsulate public mutable field in IcebergSplit#4984
Merged
rdblue merged 1 commit intoapache:masterfrom Jun 28, 2022
Merged
Conversation
`IcebergSplit.ANYWHERE` was a mutable and publicly accessible field, so someone could modify it. The modification could also be accidental, if someone modified the array returned from `IcebergSplit.locations()`.
findepi
requested review from
RussellSpitzer,
danielcweeks and
jackye1995
and removed request for
RussellSpitzer,
danielcweeks and
jackye1995
rdblue
approved these changes
Jun 28, 2022
findepi
deleted the
findepi/encapsulate-public-mutable-field-in-icebergsplit-b5534e
branch
Member
Author
|
thank you @rdblue for the merge |
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
`IcebergSplit.ANYWHERE` was a mutable and publicly accessible field, so someone could modify it. The modification could also be accidental, if someone modified the array returned from `IcebergSplit.locations()`.
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
`IcebergSplit.ANYWHERE` was a mutable and publicly accessible field, so someone could modify it. The modification could also be accidental, if someone modified the array returned from `IcebergSplit.locations()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IcebergSplit.ANYWHEREwas a mutable and publicly accessible field, sosomeone could modify it. The modification could also be accidental, if
someone modified the array returned from
IcebergSplit.locations().