Spark 3.x: Use original option keys in SparkCatalog#5044
Merged
rdblue merged 1 commit intoapache:masterfrom Jun 29, 2022
Merged
Conversation
rdblue
reviewed
Jun 28, 2022
| Configuration conf = SparkUtil.hadoopConfCatalogOverrides(SparkSession.active(), name); | ||
| Map<String, String> optionsMap = new TreeMap<>(String.CASE_INSENSITIVE_ORDER); | ||
| optionsMap.putAll(options); | ||
| Map<String, String> optionsMap = new TreeMap<>(options.asCaseSensitiveMap()); |
Contributor
There was a problem hiding this comment.
@rajarshisarkar, don't we still need to create the map with CASE_INSENSITIVE_ORDER? We want to use the original keys, but it should not force case sensitivity. So this should be:
Map<String, String> optionsMap = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
optionsMap.putAll(options.asCaseSensitiveMap());
Contributor
Author
There was a problem hiding this comment.
I see, I have made the change.
rajarshisarkar
force-pushed
the
spark-3.x-use-original-option-keys-in-spark-catalog
branch
from
56e8daf to
5782aea
Compare
rdblue
approved these changes
Jun 28, 2022
Contributor
|
@rajarshisarkar, can you fix 3.3 as well? |
rajarshisarkar
force-pushed
the
spark-3.x-use-original-option-keys-in-spark-catalog
branch
from
5782aea to
c537e8a
Compare
Contributor
Author
|
@rdblue, I have made changes for Spark 3.3 |
rdblue
approved these changes
Jun 29, 2022
Contributor
|
Thanks, @rajarshisarkar! |
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #4903
cc: @rdblue