Spark: Add __metadata_col metadata in metadata columns when doing Schema Conversion#5075
Merged
rdblue merged 2 commits intoapache:masterfrom Jun 28, 2022
Merged
Conversation
rdblue
reviewed
Jun 24, 2022
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/TypeToSparkType.java
Outdated
Show resolved
Hide resolved
rdblue
approved these changes
Jun 28, 2022
Contributor
|
Thanks, @singhpk234! |
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
…pache#5075) Co-authored-by: Prashant Singh <psinghvk@amazon.com>
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
…pache#5075) Co-authored-by: Prashant Singh <psinghvk@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the change :
Presently when doing schema conversion we were setting
metadatafor all the the columns, but we should add____metadata_colin metadata column which can be used by spark to check if the column ismetadatacol and drop it if required like,here :
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala#L221-L225
Note :
MetadataAttributeextractor uses the above key in attribute meta data to find if the attribute is metadata attribute or not.This PR includes :
(i) Fix for above
(ii) Fix an existing minor typo in
TestSparkSchemaUtilTesting Done
Added an UT for the same.
cc @rdblue @aokolnychyi @jackye1995 @RussellSpitzer