Spark: Validate HMS uri in SparkSessionCatalog#5134
Merged
rdblue merged 3 commits intoapache:masterfrom Jun 28, 2022
Merged
Conversation
rdblue
reviewed
Jun 27, 2022
|
|
||
| Preconditions.checkArgument(catalogHmsUri.equals(envHmsUri), | ||
| "The environment Hive metastore uri(%s) doesn't match with Spark session catalog uri(%s). " + | ||
| "Please make sure they are the same, or keep a valid one and unset the other.", |
Contributor
There was a problem hiding this comment.
We normally try to keep error messages short and only include tips for resolving problems if they aren't obvious. Here, I'd recommend: "Inconsistent Hive metastore URIs: %s (Spark session) != %s (spark_catalog)", envHmsUri, catalogHmsUri
rdblue
reviewed
Jun 27, 2022
| spark.sessionState().catalogManager().reset(); | ||
| spark.conf().set(envHmsUriKey, hmsUri); | ||
| spark.conf().set(catalogHmsUriKey, "RandomString"); | ||
| Assert.assertThrows(IllegalArgumentException.class, () -> spark.sessionState().catalogManager().v2SessionCatalog()); |
Contributor
There was a problem hiding this comment.
Can this validate the error message?
Contributor
Author
There was a problem hiding this comment.
Fixed in the new commit.
rdblue
approved these changes
Jun 28, 2022
Contributor
|
Thanks, @flyrain! |
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To close #2488. Open a new PR since #3126 isn't active for a while.
All comments in #3126 are resolved. Please take a look. @RussellSpitzer @rdblue @kbendick @szehon-ho @karuppayya @aokolnychyi