Spark 3.3: [FOLLOWUP] Add TODO for TimeTravel via DataframeReader using timestamp in seconds and CatalogOptions#5160
Closed
singhpk234 wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
rdblue
reviewed
Jun 29, 2022
rdblue
reviewed
Jun 29, 2022
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
Outdated
Show resolved
Hide resolved
singhpk234
changed the title
singhpk234
changed the title
Contributor
|
Should we close this since it won't be fixed in Iceberg? |
Contributor
Author
|
Sure, I just thought it would nice to document this atleast, so that we don't miss this when we upgrade to 3.3.1, but I think we should be fine either ways ! Thanks @rdblue for the review :) !! I learned about timestamp handling in iceberg / spark from this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the changes
Testing Done
cc @rdblue