Spec: Sort-order order-id is mandatory#5177
Merged
rdblue merged 1 commit intoapache:masterfrom Jul 1, 2022
Merged
Conversation
Looking at the code, we expect this field: https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/SortOrderParser.java#L154 And we always write it on the Java side.
rdblue
approved these changes
Jul 1, 2022
Contributor
|
We do require this in the parser and it is probably best if we require it all the time. There are a couple of places where we don't technically need it because the order will be reassigned. For example, when interacting with a REST-based catalog, the catalog service will add the sort order to the current metadata and reassign the ID to ensure it doesn't conflict with concurrent operations. But it's always okay to have an order ID so I think we should go ahead and require it. |
Contributor
|
Thanks, @Fokko! |
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
Looking at the code, we expect this field: https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/SortOrderParser.java#L154 And we always write it on the Java side.
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
Looking at the code, we expect this field: https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/SortOrderParser.java#L154 And we always write it on the Java side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at the code, we expect this field:
https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/SortOrderParser.java#L154
And we always write it on the Java side.
@rdblue Can you confirm this? I saw that you recently did some work on this.