More Python Expressions #5258
More Python Expressions #5258
Conversation
Co-authored-by: Fokko Driesprong <fokko@apache.org>
|
@Fokko please have another look when you get a chance. Thanks! |
| return self._literals | ||
|
|
||
| def __str__(self) -> str: | ||
| return f"{self.__class__.__name__}({str(self.term)}{self.literals and ', '+str(self.literals)})" |
There was a problem hiding this comment.
When I test this and literals is an empty list, I get x[] (where x is the term)
|
|
||
| def __str__(self) -> str: | ||
| return f"({self.left} and {self.right})" | ||
| return f"And({str(self.left)}, {str(self.right)})" |
There was a problem hiding this comment.
I don't think this is correct. This is basically just repr output. I think this should match what Java produces, which is a readable infix string.
| raise AttributeError("Null is a unary predicate and takes no Literals.") | ||
|
|
||
| def bind(self, schema: Schema, case_sensitive: bool) -> BoundIsNull[T]: | ||
| bound_ref = self.term.bind(schema, case_sensitive) |
There was a problem hiding this comment.
A better name would be bound_term since this is not necessarily a ref.
| return BoundNotEq(self.term, *self.literals) | ||
|
|
||
|
|
||
| class Eq(UnboundPredicate[T]): |
There was a problem hiding this comment.
Since we are using expression classes directly, rather than using factory methods, I think that these classes should use full names, like Equals and LessThan (or BoundEqual and BoundLessThan).
|
Thanks, @CircArgs! I think there are some changes that would help readability, but those are minor. I merged this so that other work can continue in parallel. |
4 participants
Adding EQ, LT, GT, Null, NaN - bound and unbound versions
Predicate literals validation e.g. ensure predicates that take a single literal ultimately end up as tuple of literals as
.literals, make sure unary predicates have no literals.