Skip to content

Flink: change precondition check to allow table pass in#5357

Closed
chenjunjiedada wants to merge 1 commit intoapache:masterfrom
chenjunjiedada:precondition
Closed

Flink: change precondition check to allow table pass in#5357
chenjunjiedada wants to merge 1 commit intoapache:masterfrom
chenjunjiedada:precondition

Conversation

@chenjunjiedada
Copy link
Collaborator

This change precondition to allow passing in the table instance.

Sometimes the table is already loaded and accessed before building the sink, this change can avoid load the table again.

@github-actions github-actions bot added the flink label Jul 26, 2022
Copy link
Contributor

@stevenzwu stevenzwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the need to pass in the table directly to avoid double loading on the jobmanager side. It is already supported in the current API.

tableLoader should always be provided, as it needs to be serializable to be used by the committer operator. SerializableTable won't work for committer, as it is a ready-only copy of the Table and can't be used to change table state.

I think we should not make the change in this PR.

@chenjunjiedada
Copy link
Collaborator Author

Thanks @stevenzwu for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants