Core: Commit empty op in CatalogHandlers #5566
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to apache#5536 and it probably makes sense to let `TableOperations` detect that metadata hasn't changed rather than not calling commit on the operation itself.
Contributor
|
I'm not sure that this makes sense for catalog handlers. It makes sense in operations because the operation may be included in a transaction and need to commit. But that commit will produce the same metadata and the Here, the situation is that a REST service receives a request to update a table with no changes. I think in that case it's perfectly fine to return early and send back 200. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #5536 and it probably makes sense to let
TableOperationsdetect that metadata hasn't changed rather than notcalling commit on the operation itself.