AWS: Deprecate AwsClientFactories.s3Configuration()#5592
Merged
jackye1995 merged 1 commit intoapache:masterfrom Aug 26, 2022
Merged
AWS: Deprecate AwsClientFactories.s3Configuration()#5592jackye1995 merged 1 commit intoapache:masterfrom
jackye1995 merged 1 commit intoapache:masterfrom
Conversation
rdblue
reviewed
Aug 21, 2022
| * s3UseArnRegionEnabled | ||
| * | ||
| * @deprecated Not for public use. To build an S3Configuration object, use | ||
| * S3Configuration.builder() directly. |
Contributor
There was a problem hiding this comment.
This should include a note like "will be removed in 2.0.0".
jackye1995
reviewed
Aug 24, 2022
| } | ||
|
|
||
| /** | ||
| * Build an S3Configuration object from two boolean flags, pathStyleAccess and |
Contributor
There was a problem hiding this comment.
Build an S3Configuration object from two boolean flags, pathStyleAccess and s3UseArnRegionEnabled
This part is a bit too specific, since we are just deprecating it, we can just have a simple message like "Build an S3 configuration object". The parameters should be put in the @param lines
This method was incorrectly marked as public. Deprecating it is one of the follow-up items of the following PR: apache#5555
jackye1995
approved these changes
Aug 26, 2022
Contributor
|
Thanks for the change, and thanks @rdblue for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was incorrectly marked as public. Deprecating it is one of the follow-up items of the following PR:
#5555