API: Extended some deprecation comments in API folder#5726
API: Extended some deprecation comments in API folder#5726danielcweeks merged 1 commit intoapache:masterfrom
Conversation
|
tagging @nastra @rdblue as the authors of the patches that marked these functions deprecated. cc @danielcweeks as this came up in the #deprecations channel |
|
This LGTM, @gaborkaszab can you please prefix your commit msg + PR title with |
|
@gaborkaszab please redo the commit, i dont see why i am listed as author here (merge/squash problem?) |
| private static final int DEFAULT_HISTOGRAM_RESERVOIR_SIZE = 10_000; | ||
|
|
||
| /** | ||
| * @deprecated will be removed in 2.0.0, use {@link org.apache.iceberg.metrics.Counter} instead. |
There was a problem hiding this comment.
Isn't 2.0.0 too far? Should we mention it as "will be removed after 1.0.0"?
Let's wait for @danielcweeks's response on this before addressing this.
There was a problem hiding this comment.
2.0.0 is correct since we guarantee that we won't break these APIs in minor releases.
There was a problem hiding this comment.
Thanks for the clarification.
There was a problem hiding this comment.
In theory you are only allowed to break the API in a major release bump, hence I've 2.0.0 here
There are some deprecation comments added after 0.14.0 in the API folder where there is no indication when the particular functionality is going to be dropped. I marked them to be dropped in 2.0.0.
gaborkaszab
force-pushed
the
comment_deprecation
branch
from
54e335c to
5c053f2
Compare
gaborkaszab
changed the title
Sure, added "API" prefix. |
Oh, thanks for pointing this out! I had some misunderstandings with git before pushing the PR :) |
5 participants
There are some deprecation comments added after 0.14.0 in the API folder where there is no indication when the particular functionality is going to be dropped. I marked them to be dropped in 2.0.0.