update spec for manifest_file#5746
Closed
JanKaul wants to merge 1 commit intoapache:masterfrom
JanKaul:update-spec-manifest-list
Closed
update spec for manifest_file#5746JanKaul wants to merge 1 commit intoapache:masterfrom JanKaul:update-spec-manifest-list
JanKaul wants to merge 1 commit intoapache:masterfrom
JanKaul:update-spec-manifest-list
Conversation
ajantha-bhat
approved these changes
Sep 11, 2022
Member
ajantha-bhat
left a comment
ajantha-bhat
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the contribution!
Fokko
requested changes
Sep 11, 2022
Contributor
There was a problem hiding this comment.
Thanks for opening this PR @JanKaul. This also introduced some confusion on my side. Instead of renaming the field name in the spec, Ryan suggested updating the code instead to match the spec: #5338 (comment) Feel free to take this over, and then we can just close my PR.
Author
|
Okay, thanks for the clarification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
In the spec is says the manifest_file record has a field called
added_files_count. However, in the Spark implementation it is calledadded_data_files_count.Changes from this PR
This PR updates the spec documentation to account for the implementation.