AWS: Allow users to set the assume role session name#5765
Merged
rdblue merged 20 commits intoapache:masterfrom Sep 20, 2022
Merged
AWS: Allow users to set the assume role session name#5765rdblue merged 20 commits intoapache:masterfrom
rdblue merged 20 commits intoapache:masterfrom
Conversation
Bumps [fastavro](https://github.com/fastavro/fastavro) from 1.6.0 to 1.6.1. - [Release notes](https://github.com/fastavro/fastavro/releases) - [Changelog](https://github.com/fastavro/fastavro/blob/master/ChangeLog) - [Commits](fastavro/fastavro@1.6.0...1.6.1) --- updated-dependencies: - dependency-name: fastavro dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pydantic](https://github.com/pydantic/pydantic) from 1.10.1 to 1.10.2. - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v1.10.1...v1.10.2) --- updated-dependencies: - dependency-name: pydantic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Noticed this in the output, and decided to fix it right away:
```
/Users/fokkodriesprong/Desktop/iceberg/api/src/main/java/org/apache/iceberg/transforms/UnknownTransform.java:89: warning: [ObjectsHashCodeUnnecessaryVarargs] java.util.Objects.hash(non-varargs) should be
replaced with java.util.Objects.hashCode(value) to avoid unnecessary varargs array allocations.
return Objects.hash(transform);
^
```
Consistent with Set and Remove CLI options * Python: Make Get Properties CLI options consistent with Set and Remove CLI Options * Python: Explicitly specify command names in the annotations and not infer it from the method name to fix F811 lint issues of duplicate method declaration.
* JdbcCatalog don't override namespace location if set * Add namespace location tests * Spotless
* Spark: Fix runtime jars packaging scala library files * apply review comments
This makes it easy to check the FileIO:
```
> pyiceberg files nyc.taxis
Snapshots: nyc.taxis
└── Snapshot 5937117119577207079, schema 0: file:/Users/fokkodriesprong/Desktop/docker-spark-iceberg/wh/nyc.db/taxis/metadata/snap-5937117119577207079-1-94656c4f-4c66-4600-a4ca-f30377300527.avro
└── Manifest: file:/Users/fokkodriesprong/Desktop/docker-spark-iceberg/wh/nyc.db/taxis/metadata/94656c4f-4c66-4600-a4ca-f30377300527-m0.avro
└── Datafile: file:/Users/fokkodriesprong/Desktop/docker-spark-iceberg/wh/nyc.db/taxis/data/00003-4-a245d9ee-8462-4a08-8cbc-26b8b33b9377-00001.parquet
```
rdblue
approved these changes
Sep 20, 2022
Contributor
|
Thanks, @JonasJ-ap! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User can set assume role session name by setting the
client.assume-role.session-nametag. This tag is optional. If not set, theAssumeRoleAwsClientFactoryusesiceberg-aws-+ random id as the session name.