Python: Catch ValidationError on invalid REST response#5897
Merged
Fokko merged 2 commits intoapache:masterfrom Oct 10, 2022
Merged
Python: Catch ValidationError on invalid REST response#5897Fokko merged 2 commits intoapache:masterfrom
Fokko merged 2 commits intoapache:masterfrom
Conversation
rdblue
reviewed
Oct 6, 2022
rdblue
approved these changes
Oct 6, 2022
Contributor
rdblue
left a comment
rdblue
left a comment
There was a problem hiding this comment.
Looks fine once the error message is fixed.
If an implementation of the rest catalog returns something different than we expect, we just propagate the ValidationError, which subclasses the ValueError. When using the CLI, it will tell you that the URI is not set, but actually it is, it is just invalid. This will return the json to the user, and also tell what's wrong with the response.
Fokko
force-pushed
the
fd-catch-validation-error
branch
from
bdb1b64 to
3b6c41d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an implementation of the rest catalog returns something different than we expect, we just propagate the ValidationError, which subclasses the ValueError. When using the CLI, it will tell you that the URI is not set, but actually it is, it is just invalid.
This will return the json to the user, and also tell what's wrong with the response. Hopefully users won't see this ever :)