Python: Add partition_type to partition_spec#5929
Merged
rdblue merged 1 commit intoapache:masterfrom Oct 7, 2022
Merged
Conversation
rdblue
reviewed
Oct 6, 2022
We need to construct a StructType from the PartitionSpec for the manifest evaluators
Fokko
force-pushed
the
fd-add-partition-spec-partition-type
branch
from
4973e45 to
6796035
Compare
rdblue
reviewed
Oct 7, 2022
| schema(Schema): the schema of data table | ||
| spec_id(int): any change to PartitionSpec will produce a new specId | ||
| fields(List[PartitionField): list of partition fields to produce partition values | ||
| fields(Tuple[PartitionField): list of partition fields to produce partition values |
rdblue
reviewed
Oct 7, 2022
| - Partition fields may be added later, in which case not all files would have the result field, | ||
| and it may be null. | ||
|
|
||
| There is a case where we can guarantee that a partition field in the first and only partition spec |
Contributor
There was a problem hiding this comment.
Minor: we used in documentation.
rdblue
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to construct a StructType from the PartitionSpec for the manifest evaluators