Skip to content

Minor clarification for spec #6458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RussellSpitzer merged 1 commit into from
Dec 20, 2022
Merged

Minor clarification for spec #6458

RussellSpitzer merged 1 commit into from
Dec 20, 2022

Conversation

@fwessels
Copy link
Contributor

@fwessels fwessels commented Dec 19, 2022

(use pos instead of position)

@fwessels
Minor clarification for spec
61e124a 
(use `pos` instead of `position`)
Fokko
Fokko approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @fwessels !

@RussellSpitzer RussellSpitzer merged commit e01084e into apache:master Dec 20, 2022
@RussellSpitzer
Copy link
Member

RussellSpitzer commented Dec 20, 2022

Thanks @fwessels and @Fokko + @ajantha-bhat for reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RussellSpitzer RussellSpitzer RussellSpitzer approved these changes

@Fokko Fokko Fokko approved these changes

+1 more reviewer

@ajantha-bhat ajantha-bhat ajantha-bhat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fwessels @RussellSpitzer @Fokko @ajantha-bhat