Python: Check for nans when creating literal #6462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Dec 20, 2022
| def __init__(self, value: L, value_type: Type[L]): | ||
| if value is None or not isinstance(value, value_type): | ||
| raise TypeError(f"Invalid literal value: {value!r} (not a {value_type})") | ||
| if isinstance(value, float): |
Contributor
There was a problem hiding this comment.
Python has lazy evaluation, so we can combine these in the same line 👍🏻
Suggested change
| if isinstance(value, float): | |
| if isinstance(value, float) and isnan(value): |
Contributor
Author
There was a problem hiding this comment.
Fixed! I never realized that -- good to know.
| assert "Invalid literal value: None" in str(e.value) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("literal_class", [FloatLiteral, DoubleLiteral]) |
Contributor
There was a problem hiding this comment.
Could you add one more tests where we use literal(float("NaN"))? The literal is meant as the public API, and people shouldn't necessarily initialize the specific literal instances themselves.
Contributor
|
Thanks @rubenvdg for fixing this 👏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this resolves #6230.
We could also check for nans in the
literal(.)factory, but imo that doesn't add anything really.