-
Notifications
You must be signed in to change notification settings - Fork 3k
Docs: Update documentation for Spark AddFiles procedure #6849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
szehon-ho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dramaticlly for documenting this, some review comments below
|
I updated per szehon feedback, also use intellij to reformat all tables in markdown syntax to read a little better. appreciate another look @szehon-ho and @rdblue |
|
HI @dramaticlly , sorry about this, while intellij format looks cool, would it be possible to do it in a separate pr? So we have more fine-grained commits and ease of seeing exact changes. Thanks |
aa73f4b to
0228b58
Compare
0228b58 to
b9247cf
Compare
Thank you @szehon-ho . I reverted format lint to limit the scope only for add-files |
|
@dramaticlly i chatted with @RussellSpitzer offline, do you want to make an issue to explore if we can have the SparkUtil itself return these values, instead of using snapshot summary which is missing in some cases? I am ok with this doc for this release, in any case. |
Thank you @szehon-ho , created #6961 as suggested, feel free to edit/update |
|
Merged, thanks @dramaticlly |
Based on @szehon-ho suggestion in #6797 (comment)
check_duplicate_filesin parameteradded_files_countandcheck_duplicate_filescompatibility.snapshot-id-inheritance.enabledand other caveats when using this procedureCC @szehon-ho @RussellSpitzer