Skip to content

Conversation

@dramaticlly
Copy link
Contributor

Based on @szehon-ho suggestion in #6797 (comment)

  • adds new check_duplicate_files in parameter
  • adds missing output section for both added_files_count and check_duplicate_files
  • highlight the impact of tblprop compatibility.snapshot-id-inheritance.enabled and other caveats when using this procedure

CC @szehon-ho @RussellSpitzer

@github-actions github-actions bot added the docs label Feb 15, 2023
Copy link
Member

@szehon-ho szehon-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dramaticlly for documenting this, some review comments below

@Fokko Fokko requested a review from rdblue February 17, 2023 08:27
@dramaticlly
Copy link
Contributor Author

I updated per szehon feedback, also use intellij to reformat all tables in markdown syntax to read a little better. appreciate another look @szehon-ho and @rdblue

@szehon-ho
Copy link
Member

HI @dramaticlly , sorry about this, while intellij format looks cool, would it be possible to do it in a separate pr? So we have more fine-grained commits and ease of seeing exact changes. Thanks

@dramaticlly
Copy link
Contributor Author

dramaticlly commented Feb 21, 2023

HI @dramaticlly , sorry about this, while intellij format looks cool, would it be possible to do it in a separate pr? So we have more fine-grained commits and ease of seeing exact changes. Thanks

Thank you @szehon-ho . I reverted format lint to limit the scope only for add-files

@dramaticlly
Copy link
Contributor Author

@Fokko and @rdblue can I ask for 2nd pair of eyes on docs update? Appredicated!

@szehon-ho
Copy link
Member

@dramaticlly i chatted with @RussellSpitzer offline, do you want to make an issue to explore if we can have the SparkUtil itself return these values, instead of using snapshot summary which is missing in some cases? I am ok with this doc for this release, in any case.

@dramaticlly
Copy link
Contributor Author

dramaticlly commented Feb 28, 2023

  • compatibility.snapshot-id-inheritance.enabled

Thank you @szehon-ho , created #6961 as suggested, feel free to edit/update

@szehon-ho szehon-ho merged commit d42d1e8 into apache:master Mar 2, 2023
@szehon-ho
Copy link
Member

Merged, thanks @dramaticlly

krvikash pushed a commit to krvikash/iceberg that referenced this pull request Mar 16, 2023
@dramaticlly dramaticlly deleted the add-files-doc branch June 28, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants