Python: starts_with and not_starts_with expressions
#6892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuigiCerone
changed the title
Fokko
changed the title
starts_with and not_starts_with expressions
LuigiCerone
force-pushed
the
python_expressions
branch
from
4cebb46 to
0073407
Compare
Fokko
reviewed
Feb 23, 2023
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks for picking this up @LuigiCerone I've added some suggestions for more test cases, would you be able to port those over from Java? Thanks!
|
|
||
|
|
||
| def test_starts_with() -> None: | ||
| assert StartsWith("x", "data") == parser.parse("x starts_with 'data'") |
Contributor
There was a problem hiding this comment.
I don't think starts_with is common in SQL. How about:
Suggested change
| assert StartsWith("x", "data") == parser.parse("x starts_with 'data'") | |
| assert StartsWith("x", "data") == parser.parse("x LIKE 'data*'") |
Contributor
Author
There was a problem hiding this comment.
Yes you are right about the fact that starts_with is not common in SQL. I'm just afraid that LIKE is a little misleading because in SQL it's to look for a pattern in the whole string whereas here it would just be to look for "starts with".
LuigiCerone
force-pushed
the
python_expressions
branch
2 times, most recently
from
e7d394e to
4a73eae
Compare
Fokko
reviewed
Feb 27, 2023
Contributor
Author
|
Need to update |
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
LuigiCerone
force-pushed
the
python_expressions
branch
from
45e5131 to
2a7104f
Compare
Fokko
reviewed
Mar 1, 2023
Fokko
reviewed
Mar 1, 2023
Fokko
reviewed
Mar 1, 2023
Fokko
reviewed
Mar 1, 2023
Fokko
reviewed
Mar 1, 2023
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Fokko
reviewed
Mar 2, 2023
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
A few minor nits, but apart from that it looks great. Thanks for picking this up @LuigiCerone!
Co-authored-by: Fokko Driesprong <fokko@apache.org>
LuigiCerone
force-pushed
the
python_expressions
branch
from
f1a06de to
5c60a09
Compare
Fokko
approved these changes
Mar 2, 2023
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks @LuigiCerone for fixing this! Much appreciated!
krvikash
pushed a commit
to krvikash/iceberg
that referenced
this pull request
Mar 16, 2023
* Add new expressions * Add test for new expressions * Fix tests and test visitors * Add py arrow tests * Fix visitors, fix mypy * Fix problem on ManifestEvalVisitor * Update python/pyiceberg/expressions/visitors.py Co-authored-by: Fokko Driesprong <fokko@apache.org> * Update python/tests/expressions/test_parser.py Co-authored-by: Fokko Driesprong <fokko@apache.org> * Fix test_parser tests and add more test_evaluator tests for new python operators * Fix ManifestEvalVisitor logic, add more tests * Fixes and minors from review * Add MetricsEvaluator starts_with logic and fix tests * Apply suggestions from code review Co-authored-by: Fokko Driesprong <fokko@apache.org> * Apply suggestions from code review Co-authored-by: Fokko Driesprong <fokko@apache.org> * Fix mypy error --------- Co-authored-by: Luigi Cerone <luigi.cerone@facile.it> Co-authored-by: Fokko Driesprong <fokko@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6112