Spark 3.1: Fixes bucket on binary column #7719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @jzhuge @Fokko @singhpk234 @aokolnychyi. pls also take a look when you are free. Thanks a lot. |
nastra
reviewed
Jun 1, 2023
...ark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestIcebergExpressions.java
Show resolved
Hide resolved
nastra
approved these changes
Jun 2, 2023
spark/v3.1/spark/src/test/java/org/apache/iceberg/spark/SparkTestBase.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
gentle ping @jzhuge @Fokko @singhpk234 @aokolnychyi |
Fokko
approved these changes
Jun 29, 2023
Contributor
|
Sorry for the long wait @ConeyLiu and leaving this hanging. Looking good, and thank you for the backport. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #7693 to Spark 3.1. Since
TestRequiredDistributionAndOrderingis added after Spark 3.1, we put thetestDefaultSortOnBinaryBucketedColumninTestSetWriteDistributionAndOrdering.