Core: Ensure operation can only be set to create/replace in ViewVersion #7887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
view-version-operation-check
branch
from
bae397b to
4de8e41
Compare
rdblue
reviewed
Jun 23, 2023
| Preconditions.checkArgument( | ||
| "create".equals(operation) || "replace".equals(operation), | ||
| "Invalid operation. Must be create or replace but was: %s", | ||
| operation); |
Contributor
There was a problem hiding this comment.
Won't this prevent loading any view with a bad operation? That doesn't seem like something that should completely break a view.
Contributor
|
I don't think this is necessary. Tables don't validate this and don't fail to load if it is invalid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the View Spec the
operationmust be set to eithercreateorreplace, so this makes sure that this can't be set to a random value