Remove unused GlueCatalog.fileIO field #8068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
approved these changes
Jul 17, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM, @jackye1995 could you also take a look please?
Member
Author
|
@nastra @jackye1995 what are preconditions for merging this PR? |
Contributor
|
I was mainly waiting for the original author of the code (@jackye1995) to double-check this before merging |
Member
Author
|
is there anything i can do to help move this presumably trivial PR forward? |
findepi
deleted the
findepi/remove-unused-gluecatalog-fileio-field-ad92b8
branch
Member
Author
|
thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.