Python: improve Avro parsing by caching struct types. #8076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache the struct types for ManifestEntry and ManifestFile schemas. Cache the _position_to_field_name lookup in Records if a struct type is passed. Improve StructReader to use slots and avoid isinstance() lookups on each time the structure is read, by performing the check in __init__(). Improve StructReader to determine the arguments to create_struct() once in init and reuse the result each time the structure is read, avoid a try block.
rustyconover
force-pushed
the
fix_python_avro_structs
branch
from
7b49918 to
0c2cc1d
Compare
Contributor
Author
|
Superseded by newer PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the struct types for ManifestEntry and ManifestFile schemas.
Cache the _position_to_field_name lookup in Records if a struct type is passed.
Improve StructReader to use slots and avoid isinstance() lookups on each time the structure is read, by performing the check in init().
Improve StructReader to determine the arguments to create_struct() once in init and reuse the result each time the structure is read, avoid a try block.